docs: apply line highlight only for default light mode#1453
Merged
jeromevdl merged 1 commit intoaws-powertools:mainfrom Oct 2, 2023
am29d:docs/fix-line-highlight-dark-mode
Merged
docs: apply line highlight only for default light mode#1453jeromevdl merged 1 commit intoaws-powertools:mainfrom am29d:docs/fix-line-highlight-dark-mode
jeromevdl merged 1 commit intoaws-powertools:mainfrom
am29d:docs/fix-line-highlight-dark-mode
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
jeromevdl
approved these changes
Oct 2, 2023
Contributor
|
thank you @am29d ! |
1 task
jeromevdl
pushed a commit
that referenced
this pull request
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1452
Description of changes:
This PR fixes the hard to read line highlight in dark mode. We had similar issue in TypeScript before and thanks to @shdq he noticed the same problem in Java docs.
Before:
After:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.