Skip to content

chore: apply checkstyle again#1339

Merged
scottgerring merged 5 commits intomainfrom
chore/checkstyle2
Aug 4, 2023
Merged

chore: apply checkstyle again#1339
scottgerring merged 5 commits intomainfrom
chore/checkstyle2

Conversation

@jeromevdl
Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

Looks like the latest version of Intellij or the checkstyle plugin for intellij does not format the same way than before (when I pushed my checkstyle code I was on a previous version of IntelliJ).

And looks like some formatted code has been unformatted since I pushed (bad merges or something).

So I apply it again.

@scottgerring @mriccia @eldimi @kozub @msailes @AlexeySoshin, please make sure to have checkstyle plugin installed with the latest version of IntelliJ and apply it to your changes (not to the whole project). See contributing guide. When merging main into your branches, please make sure to apply the formatting changes too.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 3, 2023

Codecov Report

❌ Patch coverage is 88.14815% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.57%. Comparing base (d0c7f91) to head (b270e4b).
⚠️ Report is 638 commits behind head on main.

Files with missing lines Patch % Lines
...mpotency/persistence/DynamoDBPersistenceStore.java 25.00% 3 Missing ⚠️
.../powertools/logging/internal/LambdaJsonLayout.java 0.00% 3 Missing ⚠️
...lambda/powertools/parameters/DynamoDbProvider.java 62.50% 3 Missing ⚠️
.../lambda/powertools/parameters/SecretsProvider.java 0.00% 3 Missing ⚠️
...ambda/powertools/parameters/AppConfigProvider.java 0.00% 2 Missing ⚠️
...zon/lambda/powertools/parameters/BaseProvider.java 94.11% 0 Missing and 1 partial ⚠️
...azon/lambda/powertools/parameters/SSMProvider.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1339      +/-   ##
============================================
- Coverage     78.78%   78.57%   -0.22%     
  Complexity      651      651              
============================================
  Files            74       74              
  Lines          2498     2506       +8     
  Branches        259      259              
============================================
+ Hits           1968     1969       +1     
- Misses          448      455       +7     
  Partials         82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mriccia
Copy link
Copy Markdown
Contributor

mriccia commented Aug 3, 2023

LGTM. I ran Checkstyle on this branch, and there were no other changes triggered.
Let's make sure e2e-tests run before merging

@scottgerring
Copy link
Copy Markdown
Contributor

Sonarqube reliability lint in examples - I have renamed the sonarqube config file on the batch branch so that we exclude examples from the copy-paste analysis. You might like to do the same here to get past the quality gate. The previous config file name was incorrect for the analysis mode we are using and had no effect.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scottgerring scottgerring merged commit 889554f into main Aug 4, 2023
@scottgerring scottgerring deleted the chore/checkstyle2 branch August 4, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants