refactor: Removes the filters set feature#26369
Merged
michael-s-molina merged 5 commits intoapache:masterfrom Jan 16, 2024
Merged
refactor: Removes the filters set feature#26369michael-s-molina merged 5 commits intoapache:masterfrom
michael-s-molina merged 5 commits intoapache:masterfrom
Conversation
michael-s-molina
added
risk:breaking-change
michael-s-molina
force-pushed
the
remove-native-filters-set
branch
from
e9e83d5 to
18343fd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26369 +/- ##
==========================================
- Coverage 69.18% 69.06% -0.13%
==========================================
Files 1948 1931 -17
Lines 76036 75355 -681
Branches 8478 8431 -47
==========================================
- Hits 52604 52042 -562
+ Misses 21265 21165 -100
+ Partials 2167 2148 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
villebro
approved these changes
Jan 5, 2024
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
LGTM. Slightly sad to see this go, but maybe we can reuse our learnings from this POC if this feature request comes up again.
Comment on lines
+33
to
+43
| module = import_module( | ||
| "superset.migrations.versions.2021-03-29_11-15_3ebe0993c770_filterset_table" | ||
| ) | ||
|
|
||
|
|
||
| def upgrade(): | ||
| module.downgrade() | ||
|
|
||
|
|
||
| def downgrade(): | ||
| module.upgrade() |
Member
There was a problem hiding this comment.
Nice, it never occurred to me we could do something like this 👍
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
As part of the 4.0 approved initiatives, this PR removes the Filters Set feature including the deprecated
DASHBOARD_NATIVE_FILTERS_SETfeature flag and all related API endpoints. The feature is permanently removed as it was not being actively maintained, it was not widely used, and it was full of bugs. We also considered that if we were to provide a similar feature, it would be better to re-implement it from scratch given the amount of technical debt that the current implementation has.The previous value of the feature flag was
Falseand now the feature is permanently removed.TESTING INSTRUCTIONS
CI should be sufficient for merging this PR. We'll do a complete testing of 4.0 after all approved proposals are merged.
ADDITIONAL INFORMATION