refactor: Removes the deprecated VERSIONED_EXPORT feature flag#26347
Merged
michael-s-molina merged 7 commits intoapache:masterfrom Jan 19, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26347 +/- ##
==========================================
- Coverage 69.56% 67.25% -2.31%
==========================================
Files 1892 1892
Lines 74162 74107 -55
Branches 8263 8254 -9
==========================================
- Hits 51593 49843 -1750
- Misses 20488 22188 +1700
+ Partials 2081 2076 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
@michael-s-molina should we put in the PR description and UPDATING.md what the flag currently defaults to? I think that would help people know what behavior to expect. |
eschutho
reviewed
Jan 8, 2024
eschutho
reviewed
Jan 8, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
As part of the 4.0 approved initiatives, this PR removes the
VERSIONED_EXPORTfeature flag.The previous value of the feature flag was
Trueand now the feature is permanently enabled.TESTING INSTRUCTIONS
CI should be sufficient for merging this PR. We'll do a complete testing of 4.0 after all approved proposals are merged.
ADDITIONAL INFORMATION