compare show missing reference files (#189)

Author: hboutemy

src/main/java/org/apache/maven/plugins/artifact/buildinfo/CompareMojo.java

@@ -166,6 +166,7 @@ private void compareWithReference(Map<Artifact, String> artifacts, File referenc
         int ok = 0;
         List<String> okFilenames = new ArrayList<>();
         List<String> koFilenames = new ArrayList<>();
+        List<String> missingFilenames = new ArrayList<>();
         List<String> diffoscopes = new ArrayList<>();
         List<String> ignored = new ArrayList<>();
         File referenceDir = referenceBuildinfo.getParentFile();
@@ -180,19 +181,19 @@ private void compareWithReference(Map<Artifact, String> artifacts, File referenc
 
             String[] checkResult = checkArtifact(artifact, prefix, reference, actual, referenceDir);
             String filename = checkResult[0];
-            String diffoscope = checkResult[1];
+            String diffoscope = checkResult[1]; // diffoscope or wget
 
             if (diffoscope == null) {
                 ok++;
                 okFilenames.add(filename);
             } else {
-                koFilenames.add(filename);
+                (diffoscope.startsWith("wget") ? missingFilenames : koFilenames).add(filename);
                 diffoscopes.add(diffoscope);
             }
         }
 
         int ko = artifacts.size() - ok - ignored.size();
-        int missing = reference.size() / 3 /* 3 property keys par file: filename, length and checksums.sha512 */;
+        int missing = missingFilenames.size();
 
         if (ko + missing > 0) {
             getLog().error("[Reproducible Builds] rebuild comparison result: "
@@ -218,6 +219,10 @@ private void compareWithReference(Map<Artifact, String> artifacts, File referenc
             p.println("okFiles=\"" + String.join(" ", okFilenames) + '"');
             p.println("koFiles=\"" + String.join(" ", koFilenames) + '"');
             p.println("ignoredFiles=\"" + String.join(" ", ignored) + '"');
+            if (missing > 0) {
+                p.println("missing=" + missing);
+                p.println("missingFiles=\"" + String.join(" ", missingFilenames) + '"');
+            }
             Properties ref = new Properties();
             if (referenceBuildinfo != null) {
                 try (InputStream in = Files.newInputStream(referenceBuildinfo.toPath())) {
@@ -267,9 +272,10 @@ private void compareWithReference(Map<Artifact, String> artifacts, File referenc
         }
     }
 
-    // { filename, diffoscope }
+    // { filename, diffoscope or wget }
     private String[] checkArtifact(
-            Artifact artifact, String prefix, Properties reference, Properties actual, File referenceDir) {
+            Artifact artifact, String prefix, Properties reference, Properties actual, File referenceDir)
+            throws MojoExecutionException {
         String actualFilename = (String) actual.remove(prefix + ".filename");
         String actualLength = (String) actual.remove(prefix + ".length");
         String actualSha512 = (String) actual.remove(prefix + ".checksums.sha512");
@@ -280,7 +286,9 @@ private String[] checkArtifact(
         reference.remove(referencePrefix + ".groupId");
 
         String issue = null;
-        if (!actualLength.equals(referenceLength)) {
+        if (referenceLength == null) {
+            issue = "missing reference file";
+        } else if (!actualLength.equals(referenceLength)) {
             issue = "size";
         } else if (!actualSha512.equals(referenceSha512)) {
             issue = "sha512";
@@ -295,7 +303,7 @@ private String[] checkArtifact(
         return new String[] {actualFilename, null};
     }
 
-    private String diffoscope(Artifact a, File referenceDir) {
+    private String diffoscope(Artifact a, File referenceDir) throws MojoExecutionException {
         File actual = a.getFile();
         // notice: actual file name may have been defined in pom
         // reference file name is taken from repository format
@@ -304,6 +312,14 @@ private String diffoscope(Artifact a, File referenceDir) {
             return "missing file for " + ArtifactIdUtils.toId(a) + " reference = " + relative(reference)
                     + " actual = null";
         }
+        if (!reference.exists()) {
+            RemoteRepository repo = createReferenceRepo();
+            String url = repo.getUrl() + "/"
+                    + session.getRepositorySession()
+                            .getLocalRepositoryManager()
+                            .getPathForRemoteArtifact(a, repo, null);
+            return "wget " + url + "; ls -l " + relative(actual);
+        }
         return "diffoscope " + relative(reference) + " " + relative(actual);
     }