Skip to content

Commit 7c12329

Browse files
authored
[Improvement-18056] Remove unused code in alert module (#18103)
1 parent 5a3563b commit 7c12329

6 files changed

Lines changed: 1 addition & 18 deletions

File tree

  • dolphinscheduler-alert/dolphinscheduler-alert-plugins

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/main/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceAlertConstants.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,6 @@ public class VoiceAlertConstants {
4343
* tts Code
4444
*/
4545
static final String TTS_CODE = "$t('ttsCode')";
46-
/**
47-
* tts Param
48-
*/
49-
static final String TTS_PARAM = "ttsParam";
50-
5146
/**
5247
* address
5348
*/

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertInputTips.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ public enum AlertInputTips {
3131
URL("input request URL", "请输入请求的URL"),
3232
HEADER("input request headers as JSON format", "请输入JSON格式的请求头"),
3333
JSON_BODY("input request body as JSON format", "请输入JSON格式的请求体"),
34-
FIELD_NAME("input alert msg field name", "请输入告警信息的内容字段名称"),
35-
HTTP_METHOD("input request type POST or GET", "请输入HTTP请求类型POST或GET"),
3634
CUSTOMIZED_PARAMS("the custom parameters passed when calling scripts", "请输入调用脚本时传入的自定义参数"),
3735
SCRIPT_PATH("the absolute script path under alert-server, and make sure access rights",
3836
"请输入alert-server机器的脚本的绝对路径,并确保文件有权接入"),

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-email/src/main/java/org/apache/dolphinscheduler/plugin/alert/email/MailParamsConstants.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ public final class MailParamsConstants {
2525
public static final String PLUGIN_DEFAULT_EMAIL_RECEIVERCCS = "$t('receiverCcs')";
2626
public static final String NAME_PLUGIN_DEFAULT_EMAIL_RECEIVERCCS = "receiverCcs";
2727

28-
public static final String NAME_MAIL_PROTOCOL = "mail.protocol";
29-
3028
public static final String MAIL_SMTP_HOST = "mail.smtp.host";
3129
public static final String NAME_MAIL_SMTP_HOST = "serverHost";
3230

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-email/src/test/java/org/apache/dolphinscheduler/plugin/alert/email/MailUtilsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public class MailUtilsTest {
4444

4545
@BeforeAll
4646
public static void initEmailConfig() {
47-
emailConfig.put(MailParamsConstants.NAME_MAIL_PROTOCOL, "smtp");
47+
emailConfig.put("mail.protocol", "smtp");
4848
emailConfig.put(MailParamsConstants.NAME_MAIL_SMTP_HOST, "xxx.xxx.com");
4949
emailConfig.put(MailParamsConstants.NAME_MAIL_SMTP_PORT, "25");
5050
emailConfig.put(MailParamsConstants.NAME_MAIL_SENDER, "xxx1.xxx.com");

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpAlertConstants.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,6 @@ public final class HttpAlertConstants {
3838

3939
public static final String NAME_BODY_PARAMS = "bodyParams";
4040

41-
public static final String CONTENT_FIELD = "$t('contentField')";
42-
43-
public static final String NAME_CONTENT_FIELD = "contentField";
44-
4541
public static final String REQUEST_TYPE = "$t('requestType')";
4642

4743
public static final String NAME_REQUEST_TYPE = "requestType";

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WeChatAlertConstants.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,8 @@ public final class WeChatAlertConstants {
3333

3434
static final String WE_CHAT_CONTENT_KEY = "content";
3535

36-
static final String WE_CHAT_MESSAGE_TYPE_TEXT = "text";
37-
3836
static final Integer WE_CHAT_MESSAGE_SAFE_PUBLICITY = 0;
3937

40-
static final Integer WE_CHAT_MESSAGE_SAFE_PRIVACY = 1;
41-
4238
static final Integer WE_CHAT_ENABLE_ID_TRANS = 0;
4339

4440
static final Integer WE_CHAT_DUPLICATE_CHECK_INTERVAL_ZERO = 0;

0 commit comments

Comments
 (0)