[Improvement-18056] Remove unused code in storage module (#18114)

Author: SbloodyS

.github/workflows/unit-test.yml

@@ -171,7 +171,7 @@ jobs:
     name: SonarCloud Analysis
     runs-on: ubuntu-latest
     needs: [ paths-filter, unit-test ]
-    if: ${{ always() && (needs.paths-filter.outputs.not-ignore == 'true' || github.event_name == 'push') }}
+    if: ${{ needs.unit-test.result == 'success' }}
     timeout-minutes: 30
     steps:
       - uses: actions/checkout@v6
@@ -250,8 +250,8 @@ jobs:
   publish-test-results:
     name: Publish Test Results
     runs-on: ubuntu-latest
-    needs: unit-test
-    if: always()
+    needs: [ paths-filter, unit-test ]
+    if: ${{ needs.unit-test.result == 'success' }}
     steps:
       - name: Download all surefire reports
         uses: actions/download-artifact@v8

dolphinscheduler-storage-plugin/dolphinscheduler-storage-abs/src/main/java/org/apache/dolphinscheduler/plugin/storage/abs/AbsStorageOperator.java

@@ -183,7 +183,7 @@ public StorageEntity getStorageEntity(String resourceAbsolutePath) {
         return null;
     }
 
-    public void checkContainerNameExists(String containerName) {
+    private void checkContainerNameExists(String containerName) {
         if (StringUtils.isBlank(containerName)) {
             throw new IllegalArgumentException(containerName + " is blank");
         }

dolphinscheduler-storage-plugin/dolphinscheduler-storage-abs/src/test/resources/logback.xml

@@ -21,42 +21,20 @@
 
 public enum StorageType {
 
-    LOCAL(0, "LOCAL"),
-    HDFS(1, "HDFS"),
-    OSS(2, "OSS"),
-    S3(3, "S3"),
-    GCS(4, "GCS"),
-
-    ABS(5, "ABS"),
-
-    OBS(6, "OBS"),
-
-    COS(7, "COS"),
-
-    ;
-
-    private final int code;
-    private final String name;
-
-    StorageType(int code, String name) {
-        this.code = code;
-        this.name = name;
-    }
-
-    public int getCode() {
-        return code;
-    }
-
-    public String getName() {
-        return name;
-    }
+    LOCAL,
+    HDFS,
+    OSS,
+    S3,
+    GCS,
+    ABS,
+    OBS,
+    COS;
 
     public static Optional<StorageType> getStorageType(String name) {
-        for (StorageType storageType : StorageType.values()) {
-            if (storageType.getName().equals(name)) {
-                return Optional.of(storageType);
-            }
+        try {
+            return Optional.of(StorageType.valueOf(name));
+        } catch (IllegalArgumentException | NullPointerException ex) {
+            return Optional.empty();
         }
-        return Optional.empty();
     }
 }

dolphinscheduler-storage-plugin/dolphinscheduler-storage-api/src/main/java/org/apache/dolphinscheduler/plugin/storage/api/StorageType.java

@@ -22,8 +22,6 @@
 @UtilityClass
 public final class StorageConstants {
 
-    public static final String RESOURCE_TYPE_FILE = "resources";
-
     /**
      * resource.hdfs.fs.defaultFS
      */

dolphinscheduler-storage-plugin/dolphinscheduler-storage-api/src/main/java/org/apache/dolphinscheduler/plugin/storage/api/constants/DateConstants.java

@@ -307,7 +307,7 @@ public StorageEntity getStorageEntity(String resourceAbsolutePath) {
         return transformCOSObjectToStorageEntity(object);
     }
 
-    public void ensureBucketSuccessfullyCreated(String bucketName) {
+    private void ensureBucketSuccessfullyCreated(String bucketName) {
         if (StringUtils.isBlank(bucketName)) {
             throw new IllegalArgumentException(CosStorageConstants.TENCENT_CLOUD_COS_BUCKET_NAME + " is empty");
         }