Merge branch 'plugin-analyzer-6' into remove-mirrors

Author: greglittlefield-wf

tools/analyzer_plugin/lib/src/assist/toggle_stateful.dart

@@ -47,7 +47,7 @@ class ToggleComponentStatefulness extends AssistContributorBase with ComponentDe
     await super.computeAssists(request, collector);
     if (!setupCompute() || !initializeAssistApi(request.result.content)) return;
 
-    newComponentBaseClass = _getNewBase(componentSupertypeNode.name.name);
+    newComponentBaseClass = _getNewBase(componentSupertypeNode.nameLexeme);
 
     // If there is no known corresponding base class, short circuit.
     if (newComponentBaseClass == null) return;

tools/analyzer_plugin/lib/src/diagnostic/exhaustive_deps.dart

@@ -34,6 +34,7 @@ import 'package:analyzer_plugin/protocol/protocol_common.dart' show Location;
 import 'package:over_react_analyzer_plugin/src/diagnostic/analyzer_debug_helper.dart';
 import 'package:over_react_analyzer_plugin/src/diagnostic_contributor.dart';
 import 'package:over_react_analyzer_plugin/src/indent_util.dart';
+import 'package:over_react_analyzer_plugin/src/over_react_builder_parsing.dart' show TypeNameHelper;
 import 'package:over_react_analyzer_plugin/src/util/ast_util.dart';
 import 'package:over_react_analyzer_plugin/src/util/function_components.dart';
 import 'package:over_react_analyzer_plugin/src/util/pretty_print.dart';
@@ -680,7 +681,7 @@ class ExhaustiveDeps extends DiagnosticContributor {
         // NamedType case. This is for references to generic type parameters
         // (references to other types will get filtered out by the isDeclaredInPureScope check above).
         (reference) {
-          dependency = reference.name.name;
+          dependency = reference.nameLexeme;
           // These aren't possible for type annotations.
           isStable = false;
           isUsedAsCascadeTarget = false;
@@ -1980,7 +1981,7 @@ _Recommendations collectRecommendations({
 String? getConstructionExpressionType(Expression node) {
   if (node is InstanceCreationExpression) {
     if (node.isConst) return null;
-    return node.constructorName.type.name.name;
+    return node.constructorName.type.nameLexeme;
   } else if (node is ListLiteral) {
     return _DepType.list;
   } else if (node is SetOrMapLiteral) {

tools/analyzer_plugin/lib/src/diagnostic/visitors/non_static_reference_visitor.dart

@@ -70,7 +70,7 @@ bool referencesImplicitThis(SimpleIdentifier identifier) {
   }
   // not a class member
   final Element? enclosingElement = element.enclosingElement;
-  if (enclosingElement is! InterfaceOrAugmentationElement) {
+  if (enclosingElement is! InterfaceElement) {
     return false;
   }
   // comment

tools/analyzer_plugin/pubspec.yaml

@@ -6,7 +6,7 @@ repository: https://github.com/Workiva/over_react/tree/master/tools/analyzer_plu
 environment:
   sdk: '>=2.19.0 <3.0.0'
 dependencies:
-  analyzer: ^5.11.0
+  analyzer: '>=5.11.0 <7.0.0'
   analyzer_plugin: ^0.11.0
   collection: ^1.15.0-nullsafety.4
   meta: ^1.16.0

tools/analyzer_plugin/test/integration/stubs.dart

@@ -101,6 +101,7 @@ class StubServerPlugin implements ServerPlugin {
   handleEditGetRefactoring(parameters) => throw UnimplementedError();
 
   @override
+  // ignore: override_on_non_overriding_member
   handleKytheGetKytheEntries(parameters) => throw UnimplementedError();
 
   @override

tools/analyzer_plugin/test/unit/util/prop_declaration/util.dart

@@ -42,6 +42,8 @@ Future<ResolvedUnitResult> resolveFileAndGeneratedPart(SharedAnalysisContext sha
       .where((e) => e.severity != Severity.info && !e.errorCode.name.toLowerCase().startsWith('unused_'))
       // FIXME(FED-2015) remove once these are properly ignored in generated code
       .where((e) => e.errorCode.name.toLowerCase() != 'invalid_use_of_visible_for_overriding_member')
+      // For some reason this is triggering for '$mustCallSuper'; ignore for now. TODO look into what's going on here
+      .where((e) => e.errorCode.name.toLowerCase() != 'invalid_annotation_target')
       .toList();
 
   final libraryResult = await getResolvedUnit(libraryFullPath);