Skip to content

Commit 4f04d73

Browse files
committed
fix wrong comment in pqihandler:UpdateRates
1 parent e41a2e5 commit 4f04d73

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

src/pqi/pqihandler.cc

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -483,12 +483,16 @@ int pqihandler::UpdateRates()
483483
{
484484
SearchModule *mod = (it -> second);
485485

486-
// for our down bandwidth we use the calculated value without taking into account the max up provided by peers via BwCtrl
487-
// this is harmless as they will control their up bw on their side
486+
// attn: the bwctrl service only passes to the peers a max in value, therefore we are not aware of our peers max out
487+
// see p3bwctrl and rsconfig.h
488+
489+
// for our down bandwidth we use the calculated value as is, because BwCtrl does not provide a max out from our peers
490+
// this down limit will be passed to our peers via BwCtrl
488491
mod -> pqi -> setMaxRate(true, in_max_bw);
489492

490-
// for our up bandwidth we take into account the max down provided by peers via BwCtrl
491-
// because we don't want to clog our outqueues, the TCP buffers, and the peers inbound queues
493+
// for our up bandwidth we take into account the max in provided by peers via BwCtrl
494+
// we don't want to clog our outqueues, the TCP buffers, and the peers inbound queues
495+
// attn: this up limit will not passed to our peers via BwCtrl
492496
mod -> pqi -> setMaxRate(false, out_max_bw);
493497
if ((rateMap_it = rateMap.find(mod->pqi->PeerId())) != rateMap.end())
494498
if (rateMap_it->second.mAllowedOut > 0)

0 commit comments

Comments
 (0)