From 936519a65e4bce171328f7a99d01f8954f07ce02 Mon Sep 17 00:00:00 2001 From: joeyaiello Date: Thu, 20 Jun 2019 10:59:32 -0700 Subject: [PATCH 1/5] add first RFC meeting notes --- notes/20190610 - RFC Discussion Notes.txt | 44 +++++++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 notes/20190610 - RFC Discussion Notes.txt diff --git a/notes/20190610 - RFC Discussion Notes.txt b/notes/20190610 - RFC Discussion Notes.txt new file mode 100644 index 000000000..ab108593b --- /dev/null +++ b/notes/20190610 - RFC Discussion Notes.txt @@ -0,0 +1,44 @@ +# RFC Meeting - June 10, 2019 + +## Attendees + +* Steve Lee +* Dongbo Wang +* Joey Aiello + +## Action Items + +* Joey: ping @charub +* Joey: write committee member RFC +* Steve: re-rev PowerShellGet 3 RFC +* Steve: PR for experimental features + +## Notes + +* Experimental Features + * Agreement to take the following out of experimental due to low risk and interactivity: + * Temp drive + * Abbreviation expansion + * Will wait for feedback to see if this should be configurable to "off" + * Will wait on Cloud Shell -> Exchange Online usage to take implicit remoting batching out of experimental + * Check to see if they enable it already today + * Will wait on "Telemetry 2.0" before we make general decision on how to take features out of experimental + * Fuzzy matching suggestion on CommandNotFound should be blocked on suggestion framework fixes + * suggestions are batched to the end of a script + * not shown in VS Code +* Outside Committee members + * AI Joey: Need to write an RFC on process for accepting outside committee members + * Nomination will be fuzzy (based on very holistic criteria) + * Needs formalized requirements on how they get accepted + * Requirements to stay on should be defined + * Apache +0/-0 system + * Requirements should maybe be loose initially just to get moving + * Definitely need to standard for removing people based on non-participation criteria (e.g. code of conduct) + * Should start small (probably with one, maybe two people) + * Geographic tradeoff: domestic is good for calls, international would push asynchronicity + * Start by looking at Apache Foundation and Debian to see their process +* Reviewed and commented on Test-Connection (#172) +* Agreed to use label "Review - Committee" for RFCs that have been partially reviewed/discussed + and may be waiting on additional review +* Need to close on PowerShell 6 specific module path (#133) once we have quorum +* @charub is back, we need to close with her on whether Environment Variable (#92) code exists From 521381f456724fa7910492a15df329df5bcace80 Mon Sep 17 00:00:00 2001 From: joeyaiello Date: Mon, 24 Jun 2019 12:26:38 -0700 Subject: [PATCH 2/5] add RFC notes for June 24, 2019 --- ...txt => 20190610 - RFC Discussion Notes.md} | 0 notes/20190624 - RFC Discussion Notes.md | 38 +++++++++++++++++++ 2 files changed, 38 insertions(+) rename notes/{20190610 - RFC Discussion Notes.txt => 20190610 - RFC Discussion Notes.md} (100%) create mode 100644 notes/20190624 - RFC Discussion Notes.md diff --git a/notes/20190610 - RFC Discussion Notes.txt b/notes/20190610 - RFC Discussion Notes.md similarity index 100% rename from notes/20190610 - RFC Discussion Notes.txt rename to notes/20190610 - RFC Discussion Notes.md diff --git a/notes/20190624 - RFC Discussion Notes.md b/notes/20190624 - RFC Discussion Notes.md new file mode 100644 index 000000000..3b7e34a51 --- /dev/null +++ b/notes/20190624 - RFC Discussion Notes.md @@ -0,0 +1,38 @@ +# RFC Meeting - June 24, 2019 + +## Attendees + +No quorum today... + +* Jim Truher +* Dongbo Wang +* Joey Aiello + +## Notes + +* PSGet 3.0 RFC has been updated, need to review with Steve when he's back +* Closed PR #138 on the basis that it misunderstood the current process +* Cursorily reviewed and briefly discussed PR 202 for side-by-side `pwsh` support + * Initial reaction is that this is explicitly a non-goal + * We are primarily trying to follow a fix-forward approach to `pwsh` + * Complexity of managing multiple namespaces in package managers is very high + * Also discouraged by distros +* Process on aging PRs out? + * `Waiting on Author` for some period of time? + * Open question: do we give it a number and reject it, or do we just close the PR? + * The former provides more visibility to others who may want to pick it up + * PR after would move it to 2-Draft-Accepted with the existing number + * Probably won't use automation to remove `Waiting on Author` + * Only the author's response would change it +* Still haven't codified the way that experimental features reduce the burden to RFCs +* Jim: "code speaks louder than words" + * Jim did ulimit/umask implementation before he submitted the PR + * At a bare minimum, input/output examples are necessary + * Dongbo: "if you're really going to implement it, you need to think about all the details up front" + * We don't want to think of the implementation plan, but having a design is critical + * One great example is Test-Connection changes (#172) + * Only 121 lines, and it gives everything you need to know about input, output, parameter sets, etc. +* We may need to be more direct about possible breakage that RFCs cause +* Reviewed login shell RFC (PR #186) + * Pending performance measurements of Rob's new method, we will take his method of `pwsh -l` / `pwsh -LoginShell` instead of using `pwsh-login` + * Open question: on a container, does Docker implicitly start the pwsh entrypoint from sh? From 53e61e03c63064e41f9fe80e13e841ad8356d91a Mon Sep 17 00:00:00 2001 From: joeyaiello Date: Mon, 1 Jul 2019 14:41:43 -0700 Subject: [PATCH 3/5] add 20190701 RFC notes --- .../20190626 - Committee Discussion Notes.md | 19 +++++++++++++++ notes/20190701 - RFC Discussion Notes.md | 23 +++++++++++++++++++ 2 files changed, 42 insertions(+) create mode 100644 notes/20190626 - Committee Discussion Notes.md create mode 100644 notes/20190701 - RFC Discussion Notes.md diff --git a/notes/20190626 - Committee Discussion Notes.md b/notes/20190626 - Committee Discussion Notes.md new file mode 100644 index 000000000..adaed04ab --- /dev/null +++ b/notes/20190626 - Committee Discussion Notes.md @@ -0,0 +1,19 @@ +# PowerShell Committee Notes - June 26, 2019 + +## Attendees + +* Jim Truher +* Dongbo Wang +* Joey Aiello +* Kenneth Hansen +* Bruce Payette + +## Agenda + +* Review labeled PowerShell issues +* Review Monday's RFC notes +* Review labeled RFC issues if we have time + +## Notes + +* Long discussion on modules refactoring/modularizing, and the amount of work involved \ No newline at end of file diff --git a/notes/20190701 - RFC Discussion Notes.md b/notes/20190701 - RFC Discussion Notes.md new file mode 100644 index 000000000..f55d79269 --- /dev/null +++ b/notes/20190701 - RFC Discussion Notes.md @@ -0,0 +1,23 @@ +# RFC Meeting - July 1, 2019 + +## Attendees + +* Steve Lee +* Dongbo Wang +* Jim Truher +* Joey Aiello + +## Notes + +* Spoke to Charu, and she believes she has an implementation of Get/Set-EnvironmentVariable to share +* Review `Out-GridView` RFC + * Meta-question: do we need to review this module if it's only shipping in the Gallery? + * RFC acceptance is not blocking publishing to the Gallery + * Jim: "given our existing backlog, we should not spend too much time on RFCs that don't ship production code directly into PowerShell" + * On its face, we don't see a problem publishing the module as written to the Gallery, but we don't + believe Avalonia can ever be shipped as part of PowerShell. +* Reviewed and merged `Test-Connection` RFC0037 (PR #172) +* Reviewed #167 regarding `-Culture` and `-Comparison` parameters on `Select-String` + * Shouldn't be too complicated: the discussion is difficult enough for us, much less for an IT admin + * If you really want full functionality of comparers, it's fine to use C# APIs + * Ultimately accepted Ilya's updated proposal 2 for its conformance to PowerShell's default case-insensitivity \ No newline at end of file From 59820b22140e3309f78f71fdb78013eb24d10f8e Mon Sep 17 00:00:00 2001 From: joeyaiello Date: Mon, 8 Jul 2019 13:55:51 -0700 Subject: [PATCH 4/5] add more notes --- .../20190703 - Committee Discussion Notes.md | 24 +++++++++++++++++++ notes/20190708 - RFC Discussion Notes.md | 24 +++++++++++++++++++ 2 files changed, 48 insertions(+) create mode 100644 notes/20190703 - Committee Discussion Notes.md create mode 100644 notes/20190708 - RFC Discussion Notes.md diff --git a/notes/20190703 - Committee Discussion Notes.md b/notes/20190703 - Committee Discussion Notes.md new file mode 100644 index 000000000..93a5a3822 --- /dev/null +++ b/notes/20190703 - Committee Discussion Notes.md @@ -0,0 +1,24 @@ +# PowerShell Committee Notes - July 3, 2019 + +## Attendees + +* Steve Lee +* Jim Truher +* Dongbo Wang +* Joey Aiello +* Kenneth Hansen + +## Notes + +* Fix New-Item -Path/-Target with wildcard char #9259 + * No attached issue for discussion + * Issue is that tab completion uses single quotes and escaped chars in what amounts to a literal path + * Agreed not to fix it in the `New-Item` behavior, but we should fix it in the tab completion +* OneDrive mode for offline vs. online files #9895 + * OneDrive uses "surrogate reparse points" for its files + * Disagreement around whether PS should report the filesystem as-is reported by the API vs. what the shell tells users in the File Explorer + * PS already matches `cmd` by reporting `Length` with parens for non-cached files + * Agreed to leave files as reporting `l` in the mode + * Jim was concerned .NET Core not making their Win32 wrapper API public + * Might make sense to add a property for surrogate reparse points to make the info scriptable +* \ No newline at end of file diff --git a/notes/20190708 - RFC Discussion Notes.md b/notes/20190708 - RFC Discussion Notes.md new file mode 100644 index 000000000..96d9b9519 --- /dev/null +++ b/notes/20190708 - RFC Discussion Notes.md @@ -0,0 +1,24 @@ +# RFC Meeting - July 8, 2019 + +## Attendees + +* Steve Lee +* Jim Truher +* Joey Aiello + +## Notes + +* Review improvement of argument generation for native executables #90 + * AI next meeting: get quorum decision + * okay implementing behind experimental feature +* Environment variable cmdlets #92 + * Charu has the code, Jim wants to give it a look +* Reviewed HTML cmdlets #137 + * Inspired meta conversation on when/how we take modules into PS Core + * Jim: "we need a 'feeder' system that allows folks to incubate modules on the Gallery" + * We need to publish a blog that gives our position on this + * AngleSharp *seems* like the best option, but we should really see an implementation +* Reviewed policy RFC #180 + * Jim had a couple concerns + * Window of opportunity as PowerShell starts where they could execute code before machine takes precedence + * User can use reflection to change object model built after policy has been applied From 588883907502341fba0f2cb3a222dd271ed7bb48 Mon Sep 17 00:00:00 2001 From: joeyaiello Date: Tue, 9 Jul 2019 10:18:56 -0700 Subject: [PATCH 5/5] fix whitespace --- notes/20190703 - Committee Discussion Notes.md | 1 - 1 file changed, 1 deletion(-) diff --git a/notes/20190703 - Committee Discussion Notes.md b/notes/20190703 - Committee Discussion Notes.md index 93a5a3822..8f6b501d8 100644 --- a/notes/20190703 - Committee Discussion Notes.md +++ b/notes/20190703 - Committee Discussion Notes.md @@ -21,4 +21,3 @@ * Agreed to leave files as reporting `l` in the mode * Jim was concerned .NET Core not making their Win32 wrapper API public * Might make sense to add a property for surrogate reparse points to make the info scriptable -* \ No newline at end of file