Skip to content

Commit dce5382

Browse files
yoshi-automationemar-kar
authored andcommitted
Add more product categories (via synth). (googleapis#9224)
1 parent e376b0f commit dce5382

9 files changed

Lines changed: 46 additions & 50 deletions

vision/google/cloud/vision_v1/proto/product_search.proto

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@ message ProductSearchParams {
4343
string product_set = 6;
4444

4545
// The list of product categories to search in. Currently, we only consider
46-
// the first category, and either "homegoods-v2", "apparel-v2", or "toys-v2"
47-
// should be specified. The legacy categories "homegoods", "apparel", and
48-
// "toys" are still supported but will be deprecated. For new products, please
49-
// use "homegoods-v2", "apparel-v2", or "toys-v2" for better product search
50-
// accuracy. It is recommended to migrate existing products to these
51-
// categories as well.
46+
// the first category, and either "homegoods-v2", "apparel-v2", "toys-v2",
47+
// "packagedgoods-v1", or "general-v1" should be specified. The legacy
48+
// categories "homegoods", "apparel", and "toys" are still supported but will
49+
// be deprecated. For new products, please use "homegoods-v2", "apparel-v2",
50+
// or "toys-v2" for better product search accuracy. It is recommended to
51+
// migrate existing products to these categories as well.
5252
repeated string product_categories = 7;
5353

5454
// The filtering expression. This can be used to restrict search results based

vision/google/cloud/vision_v1/proto/product_search_pb2.py

Lines changed: 7 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vision/google/cloud/vision_v1/proto/product_search_service.proto

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -375,9 +375,9 @@ message Product {
375375
string description = 3;
376376

377377
// The category for the product identified by the reference image. This should
378-
// be either "homegoods-v2", "apparel-v2", or "toys-v2". The legacy categories
379-
// "homegoods", "apparel", and "toys" are still supported, but these should
380-
// not be used for new products.
378+
// be either "homegoods-v2", "apparel-v2", "toys-v2", "packagedgoods-v1", or
379+
// "general-v1" The legacy categories "homegoods", "apparel", and "toys" are
380+
// still supported, but these should not be used for new products.
381381
//
382382
// This field is immutable.
383383
string product_category = 4;

vision/google/cloud/vision_v1/proto/product_search_service_pb2.py

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vision/google/cloud/vision_v1p4beta1/proto/product_search.proto

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,12 @@ message ProductSearchParams {
4444
string product_set = 6;
4545

4646
// The list of product categories to search in. Currently, we only consider
47-
// the first category, and either "homegoods-v2", "apparel-v2", "toys-v2", or
48-
// "packagedgoods-v1" should be specified. The legacy categories "homegoods",
49-
// "apparel", and "toys" are still supported but will be deprecated. For new
50-
// products, please use "homegoods-v2", "apparel-v2", or "toys-v2" for better
51-
// product search accuracy. It is recommended to migrate existing products to
52-
// these categories as well.
47+
// the first category, and either "homegoods-v2", "apparel-v2", "toys-v2",
48+
// "packagedgoods-v1", or "general-v1" should be specified. The legacy
49+
// categories "homegoods", "apparel", and "toys" are still supported but will
50+
// be deprecated. For new products, please use "homegoods-v2", "apparel-v2",
51+
// or "toys-v2" for better product search accuracy. It is recommended to
52+
// migrate existing products to these categories as well.
5353
repeated string product_categories = 7;
5454

5555
// The filtering expression. This can be used to restrict search results based

vision/google/cloud/vision_v1p4beta1/proto/product_search_pb2.py

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vision/google/cloud/vision_v1p4beta1/proto/product_search_service.proto

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -355,12 +355,9 @@ message Product {
355355
string description = 3;
356356

357357
// The category for the product identified by the reference image. This should
358-
// be either "homegoods-v2", "apparel-v2", "toys-v2", or "packagedgoods-v1".
359-
// The legacy categories "homegoods", "apparel", and "toys" are still
360-
// supported but will be deprecated. For new products, please use
361-
// "homegoods-v2", "apparel-v2", or "toys-v2" for better product search
362-
// accuracy. It is recommended to migrate existing products to these
363-
// categories as well.
358+
// be either "homegoods-v2", "apparel-v2", "toys-v2", "packagedgoods-v1", or
359+
// "general-v1" The legacy categories "homegoods", "apparel", and "toys" are
360+
// still supported, but these should not be used for new products.
364361
//
365362
// This field is immutable.
366363
string product_category = 4;

vision/google/cloud/vision_v1p4beta1/proto/product_search_service_pb2.py

Lines changed: 4 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vision/synth.metadata

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
{
2-
"updateTime": "2019-08-16T12:45:12.445594Z",
2+
"updateTime": "2019-09-13T12:40:57.067863Z",
33
"sources": [
44
{
55
"generator": {
66
"name": "artman",
7-
"version": "0.33.0",
8-
"dockerImage": "googleapis/artman@sha256:c6231efb525569736226b1f7af7565dbc84248efafb3692a5bb1d2d8a7975d53"
7+
"version": "0.36.2",
8+
"dockerImage": "googleapis/artman@sha256:0e6f3a668cd68afc768ecbe08817cf6e56a0e64fcbdb1c58c3b97492d12418a1"
99
}
1010
},
1111
{
1212
"git": {
1313
"name": "googleapis",
1414
"remote": "https://github.com/googleapis/googleapis.git",
15-
"sha": "2a02e33c79cbf23d316c57e1c78f915e1d905eee",
16-
"internalRef": "263682410"
15+
"sha": "dc88acb2ced136067d3ed2356b6a87ca7f017a96",
16+
"internalRef": "268735517"
1717
}
1818
},
1919
{

0 commit comments

Comments
 (0)