Major refactor of compiler pass and configuration tree#32
Merged
Conversation
Contributor
gorkalaucirica
commented
Sep 6, 2017
gorkalaucirica
commented
- Created ThemeConfig to store theme related configuration
- Pass stylesheets and javascripts in ThemeConfig to iframe in Twig Renderer
- Simplified theme customization using CSS variables
- Unified theme customization and related in LoadThemeConfigPass
- Modified IndexController to pass to the view the values in ThemeConfig
- Created ThemeConfig to store theme related configuration - Pass stylesheets and javascripts in ThemeConfig to iframe in Twig Renderer - Simplified theme customization using CSS variables - Unified theme customization and related in LoadThemeConfigPass - Modified IndexController to pass to the view the values in ThemeConfig
benatespina
changed the title
benatespina
changed the title
gorkalaucirica
commented
Sep 7, 2017
| 'theme' => [ | ||
| 'title' => 'LIN3S', | ||
| 'description' => 'Pattern Library Builder', | ||
| 'stylesheets' => ['https://www.euskaltel.com/assets/euskaltel.21f40baa7611ea899495aba95bc09f67.css'], |
Contributor
Author
There was a problem hiding this comment.
Remove this line
| // @author Gorka Laucirica <gorka.lauzirika@gmail.com> | ||
| // @author Mikel Tuesta <mikeltuesta@gmail.com> | ||
|
|
||
| //Default CSS Vars, can be override using configuration |
Contributor
Author
There was a problem hiding this comment.
Move this comment above :root
* Removed stylesheet parameter in loadFromExtension
gorkalaucirica
commented
Sep 7, 2017
| private $templateConfig; | ||
|
|
||
| public function __construct(\Twig_Environment $twig, RequestStack $requestStack) | ||
| public function __construct(\Twig_Environment $twig, RequestStack $requestStack, ThemeConfig $templateConfig) |
Contributor
Author
There was a problem hiding this comment.
Change $templateConfig to $themeConfig in the whole class
added 2 commits
September 7, 2017 10:26
This was referenced Sep 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.