Skip to content

Commit a1ff2db

Browse files
layers: Temp relax of VU 10582
1 parent aaa8ca0 commit a1ff2db

2 files changed

Lines changed: 11 additions & 6 deletions

File tree

layers/core_checks/cc_pipeline_graphics.cpp

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3480,11 +3480,15 @@ bool CoreChecks::ValidateDrawPipelineDynamicRenderpass(const LastBound &last_bou
34803480
const VkRenderingFlags render_flags = rp_state.GetRenderingFlags();
34813481
if ((render_flags & VK_RENDERING_CONTENTS_SECONDARY_COMMAND_BUFFERS_BIT) != 0 &&
34823482
(render_flags & VK_RENDERING_CONTENTS_INLINE_BIT_KHR) == 0) {
3483-
skip |= LogError(vuid.rendering_contents_10582, cb_state.Handle(), vuid.loc(),
3484-
"the render pass is %s::flags %s (missing VK_RENDERING_CONTENTS_INLINE_BIT_KHR)",
3485-
rp_state.use_dynamic_rendering_inherited ? "inherited with VkCommandBufferInheritanceRenderingInfo"
3486-
: "begun with VkRenderingInfo",
3487-
string_VkRenderingFlags(render_flags).c_str());
3483+
// Being discussed if this is correct or not
3484+
// https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/10761
3485+
if (!rp_state.use_dynamic_rendering_inherited) {
3486+
skip |= LogError(vuid.rendering_contents_10582, cb_state.Handle(), vuid.loc(),
3487+
"the render pass is %s::flags %s (missing VK_RENDERING_CONTENTS_INLINE_BIT_KHR)",
3488+
rp_state.use_dynamic_rendering_inherited ? "inherited with VkCommandBufferInheritanceRenderingInfo"
3489+
: "begun with VkRenderingInfo",
3490+
string_VkRenderingFlags(render_flags).c_str());
3491+
}
34883492
}
34893493

34903494
const VkPipelineRenderingCreateInfo &pipeline_rendering_ci = *(pipeline_rp_state->dynamic_pipeline_rendering_create_info.ptr());

tests/unit/secondary_command_buffer.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -926,7 +926,8 @@ TEST_F(NegativeSecondaryCommandBuffer, NestedDrawWithoutInline) {
926926
secondary.End();
927927
}
928928

929-
TEST_F(NegativeSecondaryCommandBuffer, NestedDrawWithoutInline2) {
929+
// https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/10761
930+
TEST_F(NegativeSecondaryCommandBuffer, DISABLED_NestedDrawWithoutInline2) {
930931
SetTargetApiVersion(VK_API_VERSION_1_1);
931932
AddRequiredExtensions(VK_EXT_NESTED_COMMAND_BUFFER_EXTENSION_NAME);
932933
AddRequiredExtensions(VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME);

0 commit comments

Comments
 (0)