layers: Add VK_QCOM_tile_shading render pass VUIDs and tests

Author: ZZKQcom

layers/chassis/dispatch_object.h

@@ -5,6 +5,7 @@
  * Copyright (c) 2015-2026 LunarG, Inc.
  * Copyright (c) 2015-2026 Google Inc.
  * Copyright (c) 2023-2024 RasterGrid Kft.
+ * Copyright (C) 2026 Qualcomm Technologies, Inc.
  * Modifications Copyright (C) 2025-2026 Advanced Micro Devices, Inc. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ -119,6 +120,7 @@ struct DeviceExtensionProperties {
     VkPhysicalDevicePerformanceCountersByRegionPropertiesARM renderpass_counter_by_region_props;
     VkPhysicalDeviceRayTracingInvocationReorderPropertiesEXT ray_tracing_invocation_reorder_props;
     VkPhysicalDeviceShaderLongVectorPropertiesEXT shader_long_vector_props;
+    VkPhysicalDeviceTileShadingPropertiesQCOM tile_shading_props;
 };
 
 // This object holds all static state for the device (device properties, enabled extensions/features, etc.)

layers/chassis/dispatch_object_manual.cpp

@@ -4,6 +4,7 @@
  * Copyright (c) 2015-2026 Valve Corporation
  * Copyright (c) 2015-2026 LunarG, Inc.
  * Copyright (C) 2025-2026 Advanced Micro Devices, Inc. All rights reserved.
+ * Copyright (C) 2026 Qualcomm Technologies, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -495,6 +496,8 @@ StatelessDeviceData::StatelessDeviceData(DispatchInstance* instance, VkPhysicalD
                                              &phys_dev_ext_props.renderpass_counter_by_region_props);
     instance->GetPhysicalDeviceExtProperties(physical_device, extensions.vk_ext_shader_long_vector,
                                              &phys_dev_ext_props.shader_long_vector_props);
+    instance->GetPhysicalDeviceExtProperties(physical_device, extensions.vk_qcom_tile_shading,
+                                             &phys_dev_ext_props.tile_shading_props);
 
     // None of these "check if supported" features are possible without first having gpdp2 first
     if (IsExtEnabled(extensions.vk_khr_get_physical_device_properties2)) {

layers/core_checks/cc_cmd_buffer.cpp

@@ -2067,6 +2067,47 @@ bool CoreChecks::ValidateCmdExecuteCommandsDynamicRenderingInherited(const vvl::
     return skip;
 }
 
+bool CoreChecks::PreCallValidateCmdBeginPerTileExecutionQCOM(VkCommandBuffer commandBuffer,
+                                                            const VkPerTileBeginInfoQCOM* pPerTileBeginInfo,
+                                                            const ErrorObject& error_obj) const {
+    bool skip = false;
+    const auto cb_state = GetRead<vvl::CommandBuffer>(commandBuffer);
+    const auto rp_state = cb_state->active_render_pass;
+
+    if (rp_state && !rp_state->has_tile_shading_enabled) {
+        const LogObjectList objlist(cb_state->Handle(), rp_state->Handle());
+        skip |= LogError("VUID-vkCmdBeginPerTileExecutionQCOM-None-10664", objlist, error_obj.location,
+                         "current render pass doesn't have tile shading enabled.");
+    }
+
+    return skip;
+}
+
+bool CoreChecks::PreCallValidateCmdEndPerTileExecutionQCOM(VkCommandBuffer commandBuffer,
+                                                           const VkPerTileEndInfoQCOM* pPerTileEndInfo,
+                                                           const ErrorObject& error_obj) const {
+    bool skip = false;
+    const auto cb_state = GetRead<vvl::CommandBuffer>(commandBuffer);
+    const auto rp_state = cb_state->active_render_pass;
+
+    if (rp_state) {
+        if (!cb_state->per_tile_execution_model_enabled) {
+            const LogObjectList objlist(cb_state->Handle(), rp_state->Handle());
+            skip |= LogError("VUID-vkCmdEndPerTileExecutionQCOM-None-10666", objlist, error_obj.location,
+                             "the command buffer doesn't have the per-tile execution model enabled "
+                             "in the current render pass.");
+        }
+
+        if (!rp_state->has_tile_shading_enabled) {
+            const LogObjectList objlist(cb_state->Handle(), rp_state->Handle());
+            skip |= LogError("VUID-vkCmdEndPerTileExecutionQCOM-None-10667", objlist, error_obj.location,
+                             "current render pass doesn't have tile shading enabled.");
+        }
+    }
+
+    return skip;
+}
+
 bool CoreChecks::PreCallValidateCmdDebugMarkerBeginEXT(VkCommandBuffer commandBuffer, const VkDebugMarkerMarkerInfoEXT* pMarkerInfo,
                                                        const ErrorObject& error_obj) const {
     auto cb_state = GetRead<vvl::CommandBuffer>(commandBuffer);

layers/core_checks/cc_render_pass.cpp

@@ -2,6 +2,7 @@
  * Copyright (c) 2015-2026 Valve Corporation
  * Copyright (c) 2015-2026 LunarG, Inc.
  * Copyright (C) 2015-2026 Google Inc.
+ * Copyright (C) 2026 Qualcomm Technologies, Inc.
  * Modifications Copyright (C) 2020-2022 Advanced Micro Devices, Inc. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ -654,6 +655,21 @@ bool CoreChecks::ValidateCmdBeginRenderPass(VkCommandBuffer commandBuffer, const
                                                                        pRenderPassBegin->renderArea, rp_begin_loc);
     }
 
+    if ((cb_state.begin_info_flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) != 0) {
+        if (const auto* rp_tile_shading_ci =
+                vku::FindStructInPNextChain<VkRenderPassTileShadingCreateInfoQCOM>(rp_state->create_info.pNext)) {
+            if ((rp_tile_shading_ci->flags & VK_TILE_SHADING_RENDER_PASS_ENABLE_BIT_QCOM) != 0) {
+                const LogObjectList objlist(commandBuffer, pRenderPassBegin->renderPass);
+                skip |= LogError("VUID-vkCmdBeginRenderPass2-flags-10652", objlist,
+                                 rp_begin_loc.dot(Field::renderPass),
+                                 "has been created with VkTileShadingRenderPassFlagsQCOM (%s), but commandBuffer "
+                                 "is being recorded with VkCommandBufferUsageFlags (%s).",
+                                 string_VkTileShadingRenderPassFlagsQCOM(rp_tile_shading_ci->flags).c_str(),
+                                 string_VkCommandBufferUsageFlags(cb_state.begin_info_flags).c_str());
+            }
+        }
+    }
+
     return skip;
 }
 
@@ -775,6 +791,12 @@ bool CoreChecks::ValidateCmdEndRenderPass(const vvl::CommandBuffer& cb_state, co
                          FormatHandle(query.pool).c_str(), query.subpass);
     }
 
+    if (cb_state.per_tile_execution_model_enabled) {
+        const LogObjectList objlist(cb_state.Handle(), rp_state.Handle());
+        skip |= LogError("VUID-vkCmdEndRenderPass-None-10653", objlist, error_obj.location,
+                         "per-tile execution model is still enabled in this command buffer.");
+    }
+
     return skip;
 }
 
@@ -3923,6 +3945,11 @@ bool CoreChecks::PreCallValidateCmdBeginRendering(VkCommandBuffer commandBuffer,
             commandBuffer, *counters_begin_info, objlist, 1u, layer_or_view_count, pRenderingInfo->renderArea, rendering_info_loc);
     }
 
+    if (const auto* rp_tile_shading_ci =
+            vku::FindStructInPNextChain<VkRenderPassTileShadingCreateInfoQCOM>(pRenderingInfo->pNext)) {
+        skip |= ValidateBeginRenderingTileShadingCreateInfo(*cb_state, *pRenderingInfo, *rp_tile_shading_ci, rendering_info_loc);
+    }
+
     return skip;
 }
 
@@ -4540,6 +4567,55 @@ bool CoreChecks::ValidateBeginRenderingDepthAndStencilAttachment(VkCommandBuffer
     return skip;
 }
 
+bool CoreChecks::ValidateBeginRenderingTileShadingCreateInfo(const vvl::CommandBuffer& cb_state, const VkRenderingInfo& rendering_info,
+                                                             const VkRenderPassTileShadingCreateInfoQCOM& rp_tile_shading_ci,
+                                                             const Location& rendering_info_loc) const {
+    bool skip = false;
+    const bool has_rp_enable_bit = (rp_tile_shading_ci.flags & VK_TILE_SHADING_RENDER_PASS_ENABLE_BIT_QCOM) != 0;
+    const bool has_rp_per_tile_exec_bit = (rp_tile_shading_ci.flags & VK_TILE_SHADING_RENDER_PASS_PER_TILE_EXECUTION_BIT_QCOM) != 0;
+    const auto* fragment_density_map_info =
+            vku::FindStructInPNextChain<VkRenderingFragmentDensityMapAttachmentInfoEXT>(rendering_info.pNext);
+
+    if (fragment_density_map_info && fragment_density_map_info->imageView != VK_NULL_HANDLE && has_rp_enable_bit) {
+        const LogObjectList objlist(cb_state.Handle(), fragment_density_map_info->imageView);
+        skip |= LogError("VUID-VkRenderingInfo-imageView-10643", objlist,
+                         rendering_info_loc.pNext(Struct::VkRenderingFragmentDensityMapAttachmentInfoEXT, Field::imageView),
+                         "is not VK_NULL_HANDLE, but VkRenderPassTileShadingCreateInfoQCOM::flags (%s) includes "
+                         "VK_TILE_SHADING_RENDER_PASS_ENABLE_BIT_QCOM bit.",
+                         string_VkTileShadingRenderPassFlagsQCOM(rp_tile_shading_ci.flags).c_str());
+    }
+
+    for (uint32_t index = 0; index < rendering_info.colorAttachmentCount; ++index) {
+        if (rendering_info.pColorAttachments[index].resolveMode == VK_RESOLVE_MODE_EXTERNAL_FORMAT_DOWNSAMPLE_BIT_ANDROID &&
+            has_rp_enable_bit) {
+            const LogObjectList objlist(cb_state.Handle(), rendering_info.pColorAttachments[index].resolveImageView);
+            skip |= LogError("VUID-VkRenderingInfo-resolveMode-10644", objlist,
+                             rendering_info_loc.dot(Field::pColorAttachments, index).dot(Field::resolveMode),
+                             "is VK_RESOLVE_MODE_EXTERNAL_FORMAT_DOWNSAMPLE_BIT_ANDROID, but "
+                             "VkRenderPassTileShadingCreateInfoQCOM::flags (%s) includes VK_TILE_SHADING_RENDER_PASS_ENABLE_BIT_QCOM bit",
+                             string_VkTileShadingRenderPassFlagsQCOM(rp_tile_shading_ci.flags).c_str());
+        }
+    }
+
+    if (has_rp_enable_bit && (cb_state.begin_info_flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) != 0) {
+        skip |= LogError("VUID-vkCmdBeginRendering-flags-10641", cb_state.Handle(),
+                         rendering_info_loc.pNext(Struct::VkRenderPassTileShadingCreateInfoQCOM, Field::flags),
+                         "(%s) includes VK_TILE_SHADING_RENDER_PASS_ENABLE_BIT_QCOM bit, but commandBuffer "
+                         "is being recorded with VkCommandBufferUsageFlags (%s).",
+                         string_VkTileShadingRenderPassFlagsQCOM(rp_tile_shading_ci.flags).c_str(),
+                         string_VkCommandBufferUsageFlags(cb_state.begin_info_flags).c_str());
+    }
+
+    if (has_rp_per_tile_exec_bit) {
+        skip |= LogError("VUID-vkCmdBeginRendering-flags-10642", cb_state.Handle(),
+                         rendering_info_loc.pNext(Struct::VkRenderPassTileShadingCreateInfoQCOM, Field::flags),
+                         "(%s) includes VK_TILE_SHADING_RENDER_PASS_PER_TILE_EXECUTION_BIT_QCOM bit.",
+                         string_VkTileShadingRenderPassFlagsQCOM(rp_tile_shading_ci.flags).c_str());
+    }
+
+    return skip;
+}
+
 // Flags validation error if the associated call is made inside a render pass. The apiName routine should ONLY be called outside a
 // render pass.
 bool CoreChecks::InsideRenderPass(const vvl::CommandBuffer& cb_state, const Location& loc, const char* vuid) const {
@@ -4629,6 +4705,10 @@ bool CoreChecks::ValidateCmdEndRendering(const vvl::CommandBuffer& cb_state, con
             LogError(vuid, objlist, error_obj.location, "query %" PRIu32 " from %s was began in the render pass, but never ended.",
                      query.slot, FormatHandle(query.pool).c_str());
     }
+    if (cb_state.per_tile_execution_model_enabled) {
+        skip |= LogError("VUID-vkCmdEndRendering-None-10645", cb_state.Handle(), error_obj.location,
+                         "per-tile execution model is still enabled in this command buffer.");
+    }
 
     return skip;
 }

layers/core_checks/core_validation.h

@@ -3,6 +3,7 @@
  * Copyright (c) 2015-2026 LunarG, Inc.
  * Copyright (C) 2015-2026 Google Inc.
  * Copyright (C) 2025 Arm Limited.
+ * Copyright (C) 2026 Qualcomm Technologies, Inc.
  * Modifications Copyright (C) 2020-2025 Advanced Micro Devices, Inc. All rights reserved.
  * Modifications Copyright (C) 2022-2025 RasterGrid Kft.
  *
@@ -1727,6 +1728,9 @@ class CoreChecks : public vvl::DeviceProxy {
                                                  const Location& rendering_info_loc) const;
     bool ValidateBeginRenderingDepthAndStencilAttachment(VkCommandBuffer commandBuffer, const VkRenderingInfo& rendering_info,
                                                          const Location& rendering_info_loc) const;
+    bool ValidateBeginRenderingTileShadingCreateInfo(const vvl::CommandBuffer& cb_state, const VkRenderingInfo& rendering_info,
+                                                     const VkRenderPassTileShadingCreateInfoQCOM& rp_tile_shading_ci,
+                                                     const Location& rendering_info_loc) const;
     bool PreCallValidateCmdBeginRenderingKHR(VkCommandBuffer commandBuffer, const VkRenderingInfoKHR* pRenderingInfo,
                                              const ErrorObject& error_obj) const override;
     bool PreCallValidateCmdBeginRendering(VkCommandBuffer commandBuffer, const VkRenderingInfo* pRenderingInfo,
@@ -2126,6 +2130,13 @@ class CoreChecks : public vvl::DeviceProxy {
                                              const VkRenderPassFragmentDensityMapOffsetEndInfoEXT& fdm_offset_end_info,
                                              const Location& end_info_loc) const;
 
+    bool PreCallValidateCmdBeginPerTileExecutionQCOM(VkCommandBuffer commandBuffer,
+                                                     const VkPerTileBeginInfoQCOM* pPerTileBeginInfo,
+                                                     const ErrorObject& error_obj) const override;
+    bool PreCallValidateCmdEndPerTileExecutionQCOM(VkCommandBuffer commandBuffer,
+                                                   const VkPerTileEndInfoQCOM* pPerTileEndInfo,
+                                                   const ErrorObject& error_obj) const override;
+
     class ViewportScissorInheritanceTracker;
     bool PreCallValidateCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount,
                                            const VkCommandBuffer* pCommandBuffers, const ErrorObject& error_obj) const override;

layers/state_tracker/cmd_buffer_state.cpp

@@ -3,6 +3,7 @@
  * Copyright (c) 2015-2026 LunarG, Inc.
  * Copyright (C) 2015-2026 Google Inc.
  * Copyright (c) 2025 Arm Limited.
+ * Copyright (C) 2026 Qualcomm Technologies, Inc.
  * Modifications Copyright (C) 2020,2025-2026 Advanced Micro Devices, Inc. All rights reserved.
  * Modifications Copyright (C) 2022 RasterGrid Kft.
  *
@@ -323,6 +324,7 @@ void CommandBuffer::ResetCBState() {
 
     has_render_pass_instance = false;
     resumes_render_pass_instance = false;
+    per_tile_execution_model_enabled = false;
     last_suspend_state = SuspendState::Empty;
     first_action_or_sync_command = Func::Empty;
     first_rendering_info = {};
@@ -895,6 +897,7 @@ void CommandBuffer::RecordEndRenderPass(const VkSubpassEndInfo* subpass_end_info
     SetActiveSubpass(0);
     active_framebuffer = VK_NULL_HANDLE;
     sample_locations_begin_info = {};
+    per_tile_execution_model_enabled = false;
 }
 
 static void InitDefaultRenderingAttachments(CommandBuffer::RenderingAttachment& attachments, uint32_t count) {
@@ -1061,6 +1064,7 @@ void CommandBuffer::RecordEndRendering(const VkRenderingEndInfoEXT* pRenderingEn
     RecordCommand(loc);
     active_render_pass = nullptr;
     active_color_attachments_index.clear();
+    per_tile_execution_model_enabled = false;
 }
 
 void CommandBuffer::RecordBeginCustomResolve(const Location& loc) {

layers/state_tracker/cmd_buffer_state.h

@@ -3,6 +3,7 @@
  * Copyright (c) 2015-2026 LunarG, Inc.
  * Copyright (C) 2015-2026 Google Inc.
  * Copyright (C) 2025 Arm Limited.
+ * Copyright (C) 2026 Qualcomm Technologies, Inc.
  * Modifications Copyright (C) 2020,2025-2026 Advanced Micro Devices, Inc. All rights reserved.
  * Modifications Copyright (C) 2022 RasterGrid Kft.
  *
@@ -434,6 +435,9 @@ class CommandBuffer : public RefcountedStateObject, public SubStateManager<Comma
     // True if the *first* render pass instance specifies VK_RENDERING_RESUMING_BIT
     bool resumes_render_pass_instance;
 
+    // Track VK_QCOM_tile_shading (vkCmdBeginPerTileExecutionQCOM and vkCmdEndPerTileExecutionQCOM)
+    bool per_tile_execution_model_enabled;
+
     // During recording, this tracks the current suspension state of the command buffer.
     // When recording ends, this is the suspension state at the end of the command buffer.
     // Render pass instances without RESUMING/SUSPENDING do not modify the suspension state.